-
Notifications
You must be signed in to change notification settings - Fork 134
Comments
Draft
Conversation
Contributor
|
{slots.currentUsedSlots ?? 0}
</p>
<p class="font-mono text-3xl font-semibold">
{#if slots.currentAvailableSlots}
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ 'slots.currentUsedSlots' is possibly 'null' or 'undefined'.
updateQueryParameters({
parameter: 'query',
value: '',
url: page.url,
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
{#if !error}
<PaginatedTable
let:visibleItems
{onFetch}
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Type '(err: APIErrorResponse) => void' is not assignable to type '(error: unknown) => void | undefined'.
@@ -62,7 +62,7 @@
<div class="h-0.5 rounded-full bg-inverse"></div>
<WorkflowDetail
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
content={workflow?.taskQueue}
href={routeForWorkers({
href={routeForWorkflowWorkers({
namespace: $page.params.namespace,
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
href={routeForWorkers({
href={routeForWorkflowWorkers({
namespace: $page.params.namespace,
workflow: workflow?.id,
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
let { worker }: Props = $props();
const { namespace } = $derived(page.params);
const heartbeat = $derived(worker.workerHeartbeat);
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ 'heartbeat' is possibly 'null' or 'undefined'.⚠️ Argument of type 'WorkerStatus | null | undefined' is not assignable to parameter of type 'WorkerStatus | undefined'.
<div class="flex flex-col gap-4">
<div class="flex flex-col gap-2">
<div class="flex items-center gap-3">
<WorkerStatus {status} />
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ 'heartbeat' is possibly 'null' or 'undefined'.
<span class="text-secondary">Task Queue</span>
<Link
href={routeForTaskQueue({
namespace,
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ 'heartbeat' is possibly 'null' or 'undefined'.⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
namespace,
queue: heartbeat.taskQueue,
})}
>
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ 'heartbeat' is possibly 'null' or 'undefined'.
</div>
<div class="flex flex-col">
<span class="text-secondary">Start</span>
<Timestamp
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ 'heartbeat' is possibly 'null' or 'undefined'.
{filterable}
>
<SdkLogo
sdk={worker.workerHeartbeat.sdkName.split('-')[1]}
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ 'worker.workerHeartbeat' is possibly 'null' or 'undefined'.⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
const totalActive = $derived(
workersInfo.reduce(
(acc, worker) =>
acc +
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Argument of type 'WorkerStatus | null | undefined' is not assignable to parameter of type 'WorkerStatus | undefined'.
const totalInactive = $derived(
workersInfo.reduce(
(acc, worker) =>
acc +
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Argument of type 'WorkerStatus | null | undefined' is not assignable to parameter of type 'WorkerStatus | undefined'.
request,
params: {
maximumPageSize: String(pageSize),
nextPageToken: token,
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
</div>
</div>
</header>
{#await describeWorker({ namespace, workerInstanceKey }) then data}
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Type 'IWorkerInfo | null | undefined' is not assignable to type 'IWorkerInfo'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?