-
Notifications
You must be signed in to change notification settings - Fork 157
Comments
Open
Conversation
CLA assistant check
All committers have signed the CLA.
dandavison
dandavison
approved these changes
Mar 17, 2025
Contributor
@dandavison
dandavison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Contributor
dandavison
commented
Mar 17, 2025
This was an error in #664. We should configure linter / type-checker in CI to catch this (and we should ideally have coverage showing that the branch wasn't tested). Pyright catches it (reportPossiblyUnboundVariable, but VSCode must be set to strict for this to be enabled).
Contributor
dandavison
commented
Mar 18, 2025
Extended tests so that they'll fail without this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Fixing the indent the setting of
kwargs["extra"]in the process method.Why?
When you set
workflow.logger.workflow_info_on_extra = Falseit caused the Workflow to fail with the error