-
Notifications
You must be signed in to change notification settings - Fork 157
Comments
Open
Conversation
@THardy98
THardy98
changed the title
(削除) uUpgrade on CAN (needs test) (削除ここまで)
(追記) Upgrade on CAN (needs test) (追記ここまで)
Jan 29, 2026
cretz
cretz
reviewed
Jan 30, 2026
self._current_history_length = act.history_length
self._current_history_size = act.history_size_bytes
self._continue_as_new_suggested = act.continue_as_new_suggested
self._suggested_continue_as_new_reasons = act.suggest_continue_as_new_reasons
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm from a Core side that once continue as new reasons are set on a workflow, they come over for every activation after that? (also worth confirming this for the suggested bool)
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a test (very similar to the test_workflow_history_info we were discussing) to check that CAN suggestion & reasons persist between WFTs
@THardy98
THardy98
changed the title
(削除) Upgrade on CAN (needs test) (削除ここまで)
(追記) Upgrade on CAN (waiting on core) (追記ここまで)
Feb 2, 2026
@THardy98
THardy98
changed the title
(削除) Upgrade on CAN (waiting on core) (削除ここまで)
(追記) Upgrade on CAN (追記ここまで)
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
What was changed
Propagate CAN versioning and CAN suggested reasons to Python.
Why?
Users can specify auto-upgrade behavior on CAN.
Part of Expose upgrade on continue as new in SDKs features#738
How was this tested:
Integration tests
Any docs updates needed?
Maybe?