-
Notifications
You must be signed in to change notification settings - Fork 179
Comments
due to -Werror compiler arg, build is failing on warning#760
Open
TbirdDuncan wants to merge 1 commit intotemporalio:main from
Open
due to -Werror compiler arg, build is failing on warning #760TbirdDuncan wants to merge 1 commit intotemporalio:main from
TbirdDuncan wants to merge 1 commit intotemporalio:main from
Conversation
@TbirdDuncan
TbirdDuncan
requested review from
a team,
antmendoza and
tsurdilo
as code owners
November 18, 2025 14:51
CLAassistant
commented
Nov 18, 2025
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
TristanAnderson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
1 similar comment
CLAassistant
commented
Nov 18, 2025
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
TristanAnderson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added a comment to an ignored catch block in Starter.java. Builds fail as there is a defined compiler arg: -Werror
Why?
So we can build
built and tested