-
-
Notifications
You must be signed in to change notification settings - Fork 146
Comments
fix(view): add props for width and height to x-icon#1969
fix(view): add props for width and height to x-icon #1969iamdadmin wants to merge 1 commit intotempestphp:3.x from
Conversation
iamdadmin
commented
Feb 13, 2026
Weird, I thought that checks were set for manual trigger, I know they are going to fail as it stands as the tests aren't finished, hence leaving it in draft. Sorry, had I known they'd run I wouldn't have raised it as a draft until I had clean tests!
iamdadmin
commented
Feb 13, 2026
Ready for review, I'd suggest squashing this commit as prettier which wasn't supposed to run on markdown files, ran on markdown files and really messed up the formatting, so there's some regression commits that are over the top.
@brendt
brendt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts I'd like some input on
944cddf to
744b7f9
Compare
iamdadmin
commented
Feb 16, 2026
Since there was a pile of regression commits due to some formatting errors, I rebased, and re-applied the changes to make this a cleaner commit.
Ready for review again, thanks for the feedback!
Closes #1955
Add props for width and height to x-icon, and ability to disable it entirely so it can be set in style or class
Add prop for style
Update docs
Update tests