Fixed if-statement #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

David-Sellen wants to merge 1 commit into temando:master from David-Sellen:master

Closed

Fixed if-statement #24

David-Sellen wants to merge 1 commit into temando:master from David-Sellen:master

Conversation

David-Sellen

Copy link

@David-Sellen David-Sellen commented Jul 11, 2018

Hi! Fixed if-statement related to #16 since it caused parameters and request bodies to be ignored.

@David-Sellen


 Fixed if-statement

fcf3fc7

@David-Sellen David-Sellen mentioned this pull request

Jul 23, 2018

Examples don't work, possible bug #25

Open

jhaagmans

jhaagmans suggested changes

Aug 2, 2018

View reviewed changes

src/DefinitionGenerator.ts

operationObj.requestBody = this.getRequestBodiesFromConfig(documentationConfig);

}

if (operationObj.parameters) {

if (documentationConfig.parameters) {

Copy link

@jhaagmans jhaagmans Aug 2, 2018 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:
if (documentationConfig.queryParams || documentationConfig.pathParams || documentationConfig.cookieParams || documentationConfig.requestHeaders)

However, the if statement shouldn't be needed in this piece of code, when none of these parameters are present, it will continue at line 179 of DefinitionGenerator.ts.