-
Notifications
You must be signed in to change notification settings - Fork 227
Open
Conversation
bpytlik
commented
Apr 2, 2014
Author
Is there a chance this pull request will get accepted at some point or does it violate some convention/protocol/etc within express.io I wasn't aware of? If it does, I'll just close the review and move on with my fork. Thanks.
bpytlik
commented
Aug 12, 2014
Author
Any chance this will be accepted?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #59. It adds the ability to make a route available for all existing sockets when it is routed. It passes the existing test suite and I've added a couple more tests. Please let me know if there's anything that needs to be changed.