-
Notifications
You must be signed in to change notification settings - Fork 82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (89 > 79 characters)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least two spaces before inline comment
line too long (144 > 79 characters)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Black would make changes.
line too long (97 > 79 characters)
coveralls
commented
Mar 3, 2020
@tchellomello
tchellomello
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henry54809 sorry for the long delay in reviewing this. I'm back on looking at this project more closely.
Could you re-work your PR so we can get this merged? Basically lint issues and re-testing it against the latest master branch so we can validate the change? Thanks
Added ability for configuring auto reboot using API v3 of 2017 page 82. Tested with IP2M-841B. I want this ability so I can write a script to continuously configure the device's reboot time to be X mins in the future. This is for cases where the device's networking crashes between now and X mins in the future , it can immediately reboot and come back online.