This repository was archived by the owner on Feb 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
"page has no context" issue #4
Closed
leonardoballand
wants to merge
1
commit into
taming-the-state-in-react:master
from
leonardoballand:NextReduxWrapper/Page_has_no_context
Closed
"page has no context" issue #4
leonardoballand
wants to merge
1
commit into
taming-the-state-in-react:master
from
leonardoballand:NextReduxWrapper/Page_has_no_context
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@leonardoballand
leonardoballand
commented
Nov 2, 2018
- Fix "page has no context" error
- Remove unused routes import (minor update)
- Fix Firebase import (minor update)
- Remove unused routes import - Fix Firebase import
I asked for help in my Slack Community, because I will find only time end of the week to review this. Thanks for all your help @leonardoballand 🚀
Someone else checked the PR and ran into one minor issue: #6 Let's address this before merging the PR.
Ok, I'm on it Robin!
Le mar. 11 déc. 2018 à 03:44, Robin Wieruch <notifications@github.com> a
écrit :
... Someone else checked the PR and ran into one minor issue: #6
<#6>
Let's address this before merging the PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFM-xKmDaDDFPrT_p58PsFdmUKN62vm8ks5u3xwCgaJpZM4YLWtN>
.
Closed
Closed
Fixed over here: #7 Thanks for everyone working on this issue!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.