-
-
Notifications
You must be signed in to change notification settings - Fork 51
fix(types/pagination) #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the declarations for the functions added to the "state and getters" object in the following lines https://github.com/table-library/react-table-library/blob/3b0ddab82cf7c633731087ba9534020ec9099db2/src/pagination/usePagination.ts#L136C1-L141C5 // src/pagination/usePagination.ts const stateAndGetters = { ...state, getTotalPages, getPages, getPageBoundaries, };
GOussama
commented
Oct 25, 2023
@GOussama I'm not a project contributor, I just added a suggested change to fix a type issue I was having.
Did your error happen after applying the suggested change? If not, then I don't think this is relevant to this PR and you should instead address the product owners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Added the declarations for the functions to the "state and getters" object in the following lines
So that you can get full type support when doing
pagination.state.getPages(data.nodes).map(...).