-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
systemcatch
commented
Apr 10, 2021
Hey @areed1192, congratulations on making the first PR to eiapy that isn't from me! 😆
What did you have in mind for refactoring?
areed1192
commented
Apr 11, 2021
Oh trust me I've been there 😆! For the most part when it comes to refactoring I was thinking of splitting up the main client file into a folder called epa and then having a file dedicated for each service. If you want an idea of how I'm thinking of the structure you can look at one of my repos for reference.
Let me know what you think.
@systemcatch
systemcatch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @areed1192 a few comments from me but looks good otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it meant to be a " here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @areed1192 can you confirm either way on this? Once it's done I'll merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question.
Went through and cleaned up the
README.mdfile. I was planning on doing some refactoring of the code if you're open to it.