-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Enhance fmtscan dictionary with HTML and CSS terms
#288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The passage effectively cautions against using the ambiguous term "front-end" by providing several distinct technical contexts where it has different meanings. It then offers clearer alternative terminology ("web" or "http").
While working on web integration for the assignment, fmtscan marked 'href' and 'rel' from HTML, and 'monospace' from CSS, as spelling errors - a problem also seen in sysprog21#265. Add these valid terms to the dictionary to avoid false positives and ensure reliable static analysis. This fixes the flagging issue from sysprog21#265 but leaves its request for better error details in fmtscan unaddressed. Change-Id: Ia59908e7ce9bdf4b6c9e0110d5ad061d401cbba1
6bbe55d to
e459061
Compare
fmtscan dictionary with front-end terms (削除ここまで)fmtscan dictionary with HTML and CSS terms (追記ここまで)
I've updated both the PR title and description to use "HTML and CSS terms" instead, specifying that 'href' and 'rel' come from HTML, and 'monospace' from CSS. Please let me know if anything else needs improvement!
Thank @HeatCrab for contributing!
Uh oh!
There was an error while loading. Please reload this page.
This PR updates the spelling dictionary with three terms - 'href' and 'rel' from HTML, and 'monospace' from CSS - that fmtscan marked as false positives during web integration. It fixes a flagging issue also seen in #265, ensuring reliable static analysis, but leaves #265's request for better error details in fmtscan unaddressed.
Related Issue: #265