Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Introduce REST API fallback #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jserv merged 1 commit into sysprog21:master from EricccTaiwan:rest-api
Mar 24, 2025
Merged

Conversation

Copy link
Contributor

@EricccTaiwan EricccTaiwan commented Mar 20, 2025

Switch to using the GitHub REST API as a fallback when HTML parsing fails to retrieve the commit hash from the GitHub commits page. This ensures that the script continues to work even under rate limit conditions and improves reliability. Optionally, authentication can be used to further mitigate rate limits.

Closed: #243

Change-Id: If204a6c78bb4062bc010c3370db0ea126f99e6f5

Switch to using the GitHub REST API as a fallback when HTML parsing
fails to retrieve the commit hash from the GitHub commits page. This
ensures that the script continues to work even under rate limit
conditions and improves reliability. Optionally, authentication can
be used to further mitigate rate limits.
Co-authored-by: Po-Ying Chiu <charlie910417@gmail.com>
Change-Id: I8688fdb093e88ed95326b911f198c974cd615ad4
@jserv jserv merged commit 9563d40 into sysprog21:master Mar 24, 2025
1 of 2 checks passed
Copy link
Contributor

jserv commented Mar 24, 2025

Thank @EricccTaiwan for contributing!

EricccTaiwan reacted with thumbs up emoji

@EricccTaiwan EricccTaiwan deleted the rest-api branch March 24, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jserv jserv jserv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potentially encountering a rate limit while retrieving the upstream hash in scripts/check_repo.sh.

AltStyle によって変換されたページ (->オリジナル) /