Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix xlarge breakpoint #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marinaaisa wants to merge 4 commits into swiftlang:main
base: main
Choose a base branch
Loading
from marinaaisa:r128869276/breakpoints

Conversation

@marinaaisa
Copy link
Member

@marinaaisa marinaaisa commented Jun 7, 2024

Bug/issue #128869276, if applicable:

Summary

  • Fix breakpoints, adding a maxWidth to the large one
  • Add xlarge breakpoint to TopicsLinkCardGrid

Dependencies

NA

Testing

Steps:

  1. Run a doccarchive with a TopicsLinkCardGrid component on it
  2. Test it in a xlarge viewport and assert that it shows a pager of 8 items per row
  3. Assert that when resizing from xlarge viewport to large viewport, it shows a pager of 6 items per row

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mportiz08 mportiz08 Awaiting requested review from mportiz08

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /