Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Explicit dependency on HTTPTypes #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Collaborator

@czechboy0 czechboy0 commented Dec 1, 2023

Motivation

Recent SwiftPM versions seem to be a bit stricter about using (i.e., import ...) transitive dependencies without explicitly declaring them as direct dependencies.

Modifications

Explicitly depend on the HTTPTypes module from swift-http-types.

Result

More explicitly declare the dependency graph.

Test Plan

All tests pass.

@czechboy0 czechboy0 merged commit 410d691 into swift-server:main Dec 1, 2023
@czechboy0 czechboy0 deleted the hd-explicit-dependency-http-types branch December 1, 2023 12:36
@czechboy0 czechboy0 added the 🔨 semver/patch No public API change. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjbeaumont simonjbeaumont simonjbeaumont approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /