Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add Docker Compose file for Swift 5.9.0 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Collaborator

@simonjbeaumont simonjbeaumont commented Nov 30, 2023

Motivation

As we approach 1.0 we want to make sure that we compile without warnings (or remarks) on all the Swift versions we claim to support. As discussed in apple/swift-openapi-urlsession#35, this turns out to be subtly different between 5.9.0 and 5.9.1. We cannot drop support for 5.9.0 because the latest released (non-seed) Xcode still uses 5.9.0. However 5.9.1 is the latest release for Linux.

While we don't expect to do this for all patch versions of Swift, in this instance we'd like to add a pipeline for Swift 5.9.0 until such a time that we can expect everyone to be using 5.9.1, which will be some time after an Xcode release with this version.

This will allow us to progress squashing the remarks on 5.9.1 with confidence that we aren't introducing warnings on 5.9.0, which could result in an error for adopters if they compile our generated code with warnings-as-errors.

Modifications

This PR adds a new Docker Compose file to explicitly use 5.9.0.

It leaves the existing 5.9 pipeline to pull 5.9-jammy which resolves to 5.9.1, and will continue to resolve to the latest 5.9.x version.

Result

We can now stand up a new CI pipeline for Swift 5.9.0 explicitly, which we can use this PR to validate.

Copy link
Collaborator Author

@yim-lee Please could you help us here too (same as apple/swift-openapi-generator#411). 🙏

yim-lee reacted with thumbs up emoji

Copy link
Collaborator

yim-lee commented Nov 30, 2023

@swift-server-bot test this please

1 similar comment
Copy link
Collaborator

yim-lee commented Nov 30, 2023

@swift-server-bot test this please

Copy link
Collaborator

yim-lee commented Nov 30, 2023

@simonjbeaumont Added pipeline for 5.9.0

@simonjbeaumont simonjbeaumont merged commit ddc356e into swift-server:main Nov 30, 2023
@czechboy0 czechboy0 added the semver/none No version bump required. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czechboy0 czechboy0 czechboy0 approved these changes

@yim-lee yim-lee Awaiting requested review from yim-lee

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /