-
Notifications
You must be signed in to change notification settings - Fork 15
Add Docker Compose file for Swift 5.9.0 #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
simonjbeaumont
merged 1 commit into
swift-server:main
from
simonjbeaumont:sb/add-5.9.0-pipeline
Nov 30, 2023
Merged
Add Docker Compose file for Swift 5.9.0 #33
simonjbeaumont
merged 1 commit into
swift-server:main
from
simonjbeaumont:sb/add-5.9.0-pipeline
Nov 30, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@yim-lee Please could you help us here too (same as apple/swift-openapi-generator#411). 🙏
@swift-server-bot test this please
1 similar comment
@swift-server-bot test this please
@simonjbeaumont Added pipeline for 5.9.0
czechboy0
czechboy0
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As we approach 1.0 we want to make sure that we compile without warnings (or remarks) on all the Swift versions we claim to support. As discussed in apple/swift-openapi-urlsession#35, this turns out to be subtly different between 5.9.0 and 5.9.1. We cannot drop support for 5.9.0 because the latest released (non-seed) Xcode still uses 5.9.0. However 5.9.1 is the latest release for Linux.
While we don't expect to do this for all patch versions of Swift, in this instance we'd like to add a pipeline for Swift 5.9.0 until such a time that we can expect everyone to be using 5.9.1, which will be some time after an Xcode release with this version.
This will allow us to progress squashing the remarks on 5.9.1 with confidence that we aren't introducing warnings on 5.9.0, which could result in an error for adopters if they compile our generated code with warnings-as-errors.
Modifications
This PR adds a new Docker Compose file to explicitly use
5.9.0
.It leaves the existing
5.9
pipeline to pull5.9-jammy
which resolves to5.9.1
, and will continue to resolve to the latest 5.9.x version.Result
We can now stand up a new CI pipeline for Swift 5.9.0 explicitly, which we can use this PR to validate.