-
Notifications
You must be signed in to change notification settings - Fork 16
Prep for 1.0 alpha, adapted to runtime changes in main #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -181,7 +181,7 @@ public struct AsyncHTTPClientTransport: ClientTransport { | |
| let length: HTTPClientRequest.Body.Length | ||
| switch body.length { | ||
| case .unknown: length = .unknown | ||
| case .known(let count): length = .known(count) | ||
| case .known(let count): length = .known(Int(count)) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Converting from Int64 to Int can trap. We should throw an error instead. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We're matching the AHC response header parsing behavior: https://github.com/swift-server/async-http-client/blob/c70e0856797ef826ff13627790241011f831975f/Sources/AsyncHTTPClient/AsyncAwait/HTTPClientResponse.swift#L135 If AHC changes to throwing errors, we should update the transport too. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes but no 😄 The code you linked is about parsing the content-length header and a couple lines below you are doing it like AHC. However, we are not looking at the conten-length parsing code right now. This is converting the user defined known size of the request body from an Int64 to an Int which AHC doesn't do at all right now. |
||
| } | ||
| clientRequest.body = .stream(body.map { .init(bytes: 0ドル) }, length: length) | ||
| } | ||
|
|
@@ -197,7 +197,7 @@ public struct AsyncHTTPClientTransport: ClientTransport { | |
| for header in httpResponse.headers { headerFields[.init(header.name)!] = header.value } | ||
|
|
||
| let length: HTTPBody.Length | ||
| if let lengthHeaderString = headerFields[.contentLength], let lengthHeader = Int(lengthHeaderString) { | ||
| if let lengthHeaderString = headerFields[.contentLength], let lengthHeader = Int64(lengthHeaderString) { | ||
| length = .known(lengthHeader) | ||
| } else { | ||
| length = .unknown | ||
|
|
||