Making the identityMap a String,String Dictionary #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

fwhenin wants to merge 1 commit into svn-all-fast-export:master

from fwhenin:master

Open

Making the identityMap a String,String Dictionary #57

fwhenin wants to merge 1 commit into svn-all-fast-export:master from fwhenin:master

Conversation

fwhenin

Copy link

@fwhenin fwhenin commented Oct 9, 2018

QByteArray seemed odd to me for the dictionary, and therefore when it was looking for a value by key from it, it didn't match against a string and would return empty, then add @localhost at the end for the git author. I made the changes below and it seemed to fix the problem i was running into


 Making the identityMap a String,String Dictionary

c80db59

@fwhenin fwhenin mentioned this pull request

Oct 9, 2018

Identity-Map not working #52

Open

@Vampire

Copy link

Contributor

Vampire commented Apr 15, 2020

As mentioned in the according issue, I was not able to reproduce your problem.
Now there is a test harness present.
Maybe you can add a test that is failing without your changes and is working with them? :-)