-
-
Notifications
You must be signed in to change notification settings - Fork 444
fix: use global fetch instead of @supabase/node-fetch #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/SupabaseClient.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing settings.global.fetch denies developers the ability to use a custom fetch, passed into the Supabase client's options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted! Thank you.
HI @m-shaka ! Thank you so much for your contribution! I will not be merging this PR now. I will merge it once we officially drop support for Node 18, in October. I want to make sure we don't break any users early.
That being said, I will add a reminder to merge your PR on November 1st! :D
Again, thank you very much for your patience and for contributing to Supabase!
What kind of change does this PR introduce?
Fix #914
Additional context
As I posted here, this won't work on Node.js <18
#914 (comment)