-
Notifications
You must be signed in to change notification settings - Fork 105
feat(typecheck): also replace longer type defaults #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if the change from NULL to 'critical' is desired?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, makes sense after your change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, makes sense after your change
Uh oh!
There was an error while loading. Please reload this page.
Before, we would only show type errors if the length of the default-type-value was <= than the length of the param-name it belonged to.
Now we have an API that tracks positions in text replacements even if they grow the original text, so we can show such errors:
Screenshot 2025年09月27日 at 14 26 07