-
Notifications
You must be signed in to change notification settings - Fork 103
fix: positional params #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wondering about parameter reusage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:'three' – i want to meet the person who writes syntax like this haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha yeah I did for some time two years ago :D
Uh oh!
There was an error while loading. Please reload this page.
pre-processes the query string to replace named params like
@namewith positional params like1ドル, because only the latter is supported by the postgres parser.not super happy with the way it is used for the type checker but also did not want to put that function in another crate.
also removed a
println!statement leftover from a previous pr of me.also fixed a bug in the lexer that tokenized a cast as a named parameter.
fixes #405, #454