-
-
Notifications
You must be signed in to change notification settings - Fork 51
Open
Conversation
alasdairwilson
alasdairwilson
approved these changes
Jun 11, 2026
alasdairwilson
commented
Jun 11, 2026
Member
hmm, I approved because it fixes the deprecation but the default behaviour has changed, the mode before used to default to "reflect" but now it is "ignore" so since we never se tmode our behaviour is changing from reflect to ignore so perhaps mode="reflect" should be included
unless we dont care.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Try old import and fail back to new import can be removed once scikit-image>0.20
AI Assistance Disclosure
AI tools were used for: