Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added new JavaScript questions to README #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jenesh18 wants to merge 2 commits into sudheerj:master from Jenesh18:feature-js-questions

Conversation

Copy link
Contributor

@Jenesh18 Jenesh18 commented Jan 18, 2025

This pull request enhances the repository by adding new JavaScript interview questions and their solutions to the README file. Specifically, the following updates were made:

  1. Added a detailed explanation of module scope in JavaScript, including examples and key features.
  2. Followed the existing repository's structure and formatting for consistency.
  3. Ensured the new content adds value for users preparing for JavaScript interviews

avrame and ckpinguin reacted with thumbs up emoji
Copy link
Contributor Author

Hi @avrame @ckpinguin @lliccien @avalla,
I hope you're doing well! I wanted to kindly follow up on this PR. Please let me know if there's anything I can improve or if additional details are needed. Looking forward to your feedback! 😊
Thank you for your time and effort in maintaining this project.

}

// moduleB.js
import { publicVariable, publicFunction } from './moduleA.js';
Copy link
Owner

@sudheerj sudheerj Feb 2, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jenesh18 It seems you are trying to access 'privateVariable' instead 'publicFunction' from moduleA. BTW, you are not using publicFunction anywhere in moduleB

Copy link
Contributor Author

@Jenesh18 Jenesh18 Feb 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sudheerj, I’ve updated the answer based on your feedback. The incorrect reference to privateVariable has been removed, and the usage of publicFunction has been added in the example. and I created a new PR Please review it when you get a chance. Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudheerj sudheerj sudheerj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /