-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Support middleware injected by OpenTelemetry Express Instrumentation plugin#4351
Open
a-legrand wants to merge 1 commit into
Open
Support middleware injected by OpenTelemetry Express Instrumentation plugin #4351a-legrand wants to merge 1 commit into
a-legrand wants to merge 1 commit into
Conversation
OpenTelemetry injects a proxy object into the router stack, which it uses for its tracing. This is similar to how NewRelic adds a sentinel handler to the router stack. This commit adds a similar workaround so that loopback can find the original layer. Made it more generic to just test if shimmer is used to wrap the handler
@a-legrand
a-legrand
requested review from
clark0x,
ebarault,
fabien and
zbarbuto
as code owners
September 22, 2021 16:46
arousselotvi
arousselotvi
approved these changes
Dec 17, 2024
Whats the status here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenTelemetry Express Instrumentation injects a proxy object into the router stack, which it
uses for its tracing. This is similar to how NewRelic adds a sentinel handler to the router stack. This commit adds a similar workaround so that loopback can find the original layer.
I made the variable more generic to just test if shimmer is used to wrap the handler, as this library can be used by other libraries.
See also #4119
Checklist