-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: upgrade nodemailer#4340
Merged
Merged
Conversation
@jannyHou
jannyHou
requested review from
bajtos,
clark0x,
ebarault,
fabien and
zbarbuto
as code owners
November 23, 2020 20:31
bajtos
commented
Nov 24, 2020
Member
Please don't use chore: prefix for significant upgrades of dependencies. Quoting from https://loopback.io/doc/en/lb4/code-contrib-lb4.html#type:
chore: Changes to the auxiliary tools and libraries such as documentation generation
We don't use conventional commits in this repository, so there is no need to use a type prefix. If you like to keep the prefix, then I am proposing to use feat: or fix:.
bajtos
bajtos
approved these changes
Nov 24, 2020
@bajtos
bajtos
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM, please improve the commit message per my comment above ☝🏻
Signed-off-by: jannyHou <juehou@ca.ibm.com>
@jannyHou
jannyHou
force-pushed
the
upgrade-nodemailer
branch
from
November 24, 2020 16:57
71891f3 to
6f04b61
Compare
jannyHou
commented
Nov 24, 2020
Contributor
Author
Tested with my gmail:
jannyHous-MBP:test jannyhou$ npm ls nodemailer
test@1.0.0 /Users/jannyhou/Desktop/Nov/test
├─┬ loopback@3.27.0
│ └── UNMET DEPENDENCY nodemailer@4.7.0 (npm link somehow doesn't work ,so I remove it manually)
└── nodemailer@6.4.16
email sent! {
accepted: [ 'juehou4102@gmail.com' ],
rejected: [],
envelopeTime: 243,
messageTime: 1579,
messageSize: 566,
response: '250 2.0.0 OK 1606244464 t7sm13254038qti.83 - gsmtp',
envelope: { from: 'jannyhou2015@gmail.com', to: [ 'juehou4102@gmail.com' ] },
messageId: '<d05d4cec-103c-bcbe-5f41-a8fe2890bde3@gmail.com>'
}
@delete-merged-branch
delete-merged-branch
Bot
deleted the
upgrade-nodemailer
branch
November 24, 2020 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connect to #4339
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine