Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: upgrade nodemailer#4340

Merged
jannyHou merged 1 commit into
master from
upgrade-nodemailer
Nov 24, 2020
Merged

chore: upgrade nodemailer #4340
jannyHou merged 1 commit into
master from
upgrade-nodemailer

Conversation

@jannyHou

@jannyHou jannyHou commented Nov 23, 2020

Copy link
Copy Markdown
Contributor

connect to #4339

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

bajtos commented Nov 24, 2020

Copy link
Copy Markdown
Member

Please don't use chore: prefix for significant upgrades of dependencies. Quoting from https://loopback.io/doc/en/lb4/code-contrib-lb4.html#type:

chore: Changes to the auxiliary tools and libraries such as documentation generation

We don't use conventional commits in this repository, so there is no need to use a type prefix. If you like to keep the prefix, then I am proposing to use feat: or fix:.

jannyHou reacted with thumbs up emoji

@bajtos bajtos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, please improve the commit message per my comment above ☝🏻

Signed-off-by: jannyHou <juehou@ca.ibm.com>

Copy link
Copy Markdown
Contributor Author

Tested with my gmail:

jannyHous-MBP:test jannyhou$ npm ls nodemailer
test@1.0.0 /Users/jannyhou/Desktop/Nov/test
├─┬ loopback@3.27.0
│ └── UNMET DEPENDENCY nodemailer@4.7.0 (npm link somehow doesn't work ,so I remove it manually)
└── nodemailer@6.4.16
email sent! {
 accepted: [ 'juehou4102@gmail.com' ],
 rejected: [],
 envelopeTime: 243,
 messageTime: 1579,
 messageSize: 566,
 response: '250 2.0.0 OK 1606244464 t7sm13254038qti.83 - gsmtp',
 envelope: { from: 'jannyhou2015@gmail.com', to: [ 'juehou4102@gmail.com' ] },
 messageId: '<d05d4cec-103c-bcbe-5f41-a8fe2890bde3@gmail.com>'
}

@jannyHou jannyHou merged commit fbd9783 into master Nov 24, 2020
@delete-merged-branch delete-merged-branch Bot deleted the upgrade-nodemailer branch November 24, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clark0x clark0x Awaiting requested review from clark0x

@ebarault ebarault Awaiting requested review from ebarault ebarault is a code owner

@fabien fabien Awaiting requested review from fabien fabien is a code owner

@zbarbuto zbarbuto Awaiting requested review from zbarbuto zbarbuto is a code owner

1 more reviewer

@bajtos bajtos bajtos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /