-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Conversation
@iCloudsPWASaaS
iCloudsPWASaaS
requested review from
bajtos,
clark0x,
ebarault,
fabien and
zbarbuto
as code owners
July 15, 2020 20:22
bajtos
commented
Jul 16, 2020
Member
Thank you @WebScaffolder for the pull request. Could you please provide more context about what are you trying to accomplish? The package loopback-datasource-juggler is intentionally listed as a dependency, see e.g. https://loopback.io/doc/en/lb3/Migrating-to-3.0.html#edit-packagejson
bajtos
commented
Jul 16, 2020
Member
I am closing the pull request as rejected for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine