-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Conversation
@hacksparrow
hacksparrow
requested review from
bajtos,
clark0x,
ebarault,
fabien and
zbarbuto
as code owners
December 12, 2019 10:16
@hacksparrow
hacksparrow
force-pushed
the
chore/update-juggler
branch
3 times, most recently
from
December 12, 2019 11:13
a5152c7 to
138dddd
Compare
Updated Juggler to 4.x
@hacksparrow
hacksparrow
force-pushed
the
chore/update-juggler
branch
from
December 12, 2019 11:19
138dddd to
3b3c199
Compare
bajtos
commented
Dec 12, 2019
Member
Updating juggler to 4.x is a breaking change that's against our Long Term Support policy, see https://loopback.io/doc/en/contrib/Long-term-support.html
Member
It was our intentional decision to keep loopback@3 to depend on loopback-datasource-juggler@3, the same way as loopback@2 depends on loopback-datasource-juggler@2.
I am open to discuss what would be the impact (both positive and negative) of upgrading LB3 to juggler v4. Unfortunately, your pull request description does not provide any clues on your motivation for this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Juggler to 4.x.