-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: provide better error message when hasone relation returns null#4288
Closed
sujeshthekkepatt wants to merge 2 commits into
Closed
feat: provide better error message when hasone relation returns null #4288sujeshthekkepatt wants to merge 2 commits into
sujeshthekkepatt wants to merge 2 commits into
Conversation
@sujeshthekkepatt
sujeshthekkepatt
requested review from
bajtos,
clark0x,
ebarault,
fabien and
zbarbuto
as code owners
November 30, 2019 10:08
slnode
commented
Nov 30, 2019
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."
The current hasone relation error message is not an appropriate one when there is no data. The 404 error code seems fine but message is not. So adds a better error message when the relation contains no data. prlint fixes
@sujeshthekkepatt
sujeshthekkepatt
deleted the
fix/hasone-relation-error-message
branch
November 30, 2019 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The current hasone relation error message is not an appropriate one when there is no data. The 404 error code seems fine but the message is not. So adds a better error message when the relation contains no data.
See more #4278
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine