Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update dev dependencies + switch from "var" to "const"#4267

Merged
bajtos merged 5 commits into
master from
update-dev-deps
Oct 8, 2019
Merged

Update dev dependencies + switch from "var" to "const" #4267
bajtos merged 5 commits into
master from
update-dev-deps

Conversation

@bajtos

@bajtos bajtos commented Oct 7, 2019

Copy link
Copy Markdown
Member
  • update chai to v4, dirty-chai to v2
  • update eslint & eslint-config to latest; fix linting errors
  • update remaining dev-dependencies

It's best to review the changes commit-by-commit and skip review of fixup! eslint --fix ..

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

3z3qu13l reacted with thumbs up emoji
@bajtos bajtos self-assigned this Oct 7, 2019
@bajtos bajtos changed the title (削除) Update dev dependencies (削除ここまで) (追記) Update dev dependencies + switch from "var" to "const" (追記ここまで) Oct 7, 2019
@bajtos bajtos requested review from a team October 7, 2019 09:54
bajtos added 5 commits October 7, 2019 11:54
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos bajtos merged commit f2f0b3a into master Oct 8, 2019
@delete-merged-branch delete-merged-branch Bot deleted the update-dev-deps branch October 8, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes

@jannyHou jannyHou jannyHou approved these changes

@dhmlau dhmlau dhmlau approved these changes

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@agnes512 agnes512 agnes512 approved these changes

@clark0x clark0x Awaiting requested review from clark0x

@ebarault ebarault Awaiting requested review from ebarault ebarault is a code owner

@fabien fabien Awaiting requested review from fabien fabien is a code owner

@zbarbuto zbarbuto Awaiting requested review from zbarbuto zbarbuto is a code owner

+1 more reviewer

@emonddr emonddr emonddr approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /