-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Improve issue & pull-request templates#4266
Merged
Merged
Conversation
Make it easier for contributors to mix the text provided by GitHub from the commit messages with the template content. Rework the checklist to follow the style we use in loopback-next. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos
bajtos
requested review from
clark0x,
ebarault,
fabien and
zbarbuto
as code owners
October 4, 2019 08:53
dhmlau
dhmlau
reviewed
Oct 4, 2019
@dhmlau
dhmlau
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bajtos for adding the templates. I have some suggestions in the review comments. Thanks.
bajtos
commented
Oct 4, 2019
Member
Author
@dhmlau I added links to LB4, LGTY now?
@bajtos
bajtos
force-pushed
the
improve/github-templates
branch
from
October 4, 2019 14:06
e1e3176 to
87cd160
Compare
dhmlau
dhmlau
approved these changes
Oct 4, 2019
@bajtos
bajtos
force-pushed
the
improve/github-templates
branch
from
October 4, 2019 14:23
87cd160 to
ff9c212
Compare
nabdelgadir
nabdelgadir
approved these changes
Oct 5, 2019
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos
bajtos
force-pushed
the
improve/github-templates
branch
from
October 7, 2019 08:35
ff9c212 to
bd276d5
Compare
This was referenced Oct 7, 2019
@delete-merged-branch
delete-merged-branch
Bot
deleted the
improve/github-templates
branch
October 7, 2019 09:10
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull requests
Make it easier for contributors to mix the text provided by GitHub
from the commit messages with the template content.
Rework the checklist to follow the style we use in loopback-next.
Issues
Introduce four different templates for different issue types: