-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: disallow queries in username and email fields [2.x]#4213
Merged
Merged
Conversation
Username and email fields should not allow queries.
dhmlau
dhmlau
approved these changes
Jun 4, 2019
@dhmlau
dhmlau
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Compared the changes in the PR in master https://github.com/strongloop/loopback/pull/4208/files.
jannyHou
commented
Jun 4, 2019
Contributor
Author
The failure on Node.js 4.x is not related to the code.
It fails on my local as well:
https://gist.github.com/jannyHou/4d1bd77a39d0bfb59305759ac3b8fb8a
Let's fix it in a separate PR.
b-admike
b-admike
approved these changes
Jun 4, 2019
@b-admike
b-admike
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
raymondfeng
raymondfeng
approved these changes
Jun 4, 2019
@bajtos
bajtos
changed the title
(削除) fix: disallow queries in username and email fields (削除ここまで)
(追記) fix: disallow queries in username and email fields [2.x] (追記ここまで)
Jun 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A backport PR to fix #4195 in loopback 2.x
Username and email fields should not allow queries.
Related issues
Checklist
guide