-
Notifications
You must be signed in to change notification settings - Fork 1k
[CI] Update after arduino-cli change #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@fpistm
fpistm
force-pushed
the
CLI_output
branch
3 times, most recently
from
July 1, 2020 15:37
c82ae8d to
2dd9039
Compare
Build with arduino-cli 0.11.0 failed, it seems there is a regression with the arduino-cli: arduino/arduino-cli#759
@fpistm
fpistm
force-pushed
the
CLI_output
branch
4 times, most recently
from
July 2, 2020 15:57
929283e to
14b7e4f
Compare
Since arduino-cli v0.11.0 '-o' options has been removed. The script does not handle properly this case which raised a command usage error. Error: unknown shorthand flag: 'o' in -o Usage: arduino-cli compile [flags] So this fix allows to properly handle it. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
With new arduino-cli v0.11.0, output management has changed. See arduino/arduino-cli#687 Binaries are always copied. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
If the executed command failed return the output and the error code. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
fpistm
force-pushed
the
CLI_output
branch
from
July 2, 2020 16:26
14b7e4f to
6da8759
Compare
@fpistm
fpistm
changed the title
(削除) [CI] Update binary management after cli change. (削除ここまで)
(追記) [CI] Update after cli change. (追記ここまで)
Jul 2, 2020
@fpistm
fpistm
changed the title
(削除) [CI] Update after cli change. (削除ここまで)
(追記) [CI] Update after arduin-cli change (追記ここまで)
Jul 2, 2020
@fpistm
fpistm
changed the title
(削除) [CI] Update after arduin-cli change (削除ここまで)
(追記) [CI] Update after arduino-cli change (追記ここまで)
Jul 2, 2020
This reverts commit b12a554.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
With new arduino-cli v0.11.0, output management has changed.
See arduino/arduino-cli#687
Harden the exception management to have a better output result.