-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Conversation
Replace the single global mutex + RandomEvictionCache with 16 sharded caches (each with its own mutex) so concurrent signature verification threads no longer block on a shared lock. Also use the single-lookup maybeGet() in place of the exists()/get() double-lookup and use Rust verification unconditionally.
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reduces lock contention in the global Ed25519 signature-verification result cache by sharding it into multiple independently-locked caches, improving throughput when signature verification occurs concurrently across threads. It also removes the protocol-gated switch to Rust ed25519-dalek verification and uses the Rust verifier unconditionally.
Changes:
- Replace the single global
RandomEvictionCache+ mutex with 16 sharded caches (one mutex per shard). - Switch cache lookups from
exists()/get()tomaybeGet()to avoid a double hash-table lookup on hits. - Remove the protocol-version-triggered
enableRustDalekVerify()mechanism and always verify via the Rust dalek bridge.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/ApplicationImpl.cpp | Removes protocol-version-based enablement of Rust dalek verification during startup. |
| src/ledger/LedgerManagerImpl.cpp | Removes protocol-version-based enablement of Rust dalek verification when setting LCL. |
| src/herder/Upgrades.cpp | Removes Rust dalek enablement at the protocol version upgrade boundary. |
| src/crypto/test/CryptoTests.cpp | Removes explicit test-time enabling of Rust dalek verification. |
| src/crypto/SecretKey.h | Removes the enableRustDalekVerify() declaration and related comments. |
| src/crypto/SecretKey.cpp | Implements sharded verifySig cache, atomic hit/miss counters, and unconditional Rust dalek verification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the single global mutex + RandomEvictionCache with 16 sharded caches (each with its own mutex) so concurrent signature verification threads no longer block on a shared lock.
Also use the single-lookup maybeGet() in place of the exists()/get() double-lookup and use Rust verification unconditionally (an overdue cleanup).
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)