-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add blas/ext/base/ndarray/scusumpw
#9064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
MeKaustubh07
commented
Dec 15, 2025
@kgryte :
I’d appreciate your guidance on a test-related change I have done. I had to modify lines 91–119 in blas/ext/base/ndarray/scusumpw/test/test.js because those cases involve signed zeros, which pairwise summation does not handle in a well-defined or compatible way.
Could you please advise on the correct or preferred approach for handling these cases—whether the tests should be adjusted, relaxed, or structured differently to align with the expected behavior of pairwise summation?
Uh oh!
There was an error while loading. Please reload this page.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: na
task: lint_c_examples status: na
task: lint_c_benchmarks status: na
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed
Resolves None.
Description
What is the purpose of this pull request?
This pull request:
blas/ext/base/ndarray/scusumpwRelated Issues
Does this pull request have any related issues?
This pull request has the following related issues:
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.
AI Assistance
When authoring the changes proposed in this PR, did you use any kind of AI assistance?
If you answered "yes" above, how did you use AI assistance?
Disclosure
If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".
This PR was created by duplicating the
scusumkbnpackage and adapting it to compute the maximum absolute value instead of the maximum value. GitHub Copilot assisted with updating test cases, documentation, and verifying consistency across all files.@stdlib-js/reviewers