Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix(lint): fix JavaScript lint errors #8143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zuhair-CS wants to merge 0 commits into stdlib-js:develop from Zuhair-CS:develop

Conversation

Copy link
Contributor

@Zuhair-CS Zuhair-CS commented Sep 25, 2025 •
edited
Loading

Fix JavaScript lint errors #8140

Description

What is the purpose of this pull request?

This pull request:

  • Fixed linting issues, a file named "beep.js" used to exist but is no longer existing, so the node module cache of beep.js was slipping in the linting process which gave the linting error by changing "tools/make/lib/lint/javascript/eslint.mk." to exclude node modules while linting.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Sep 25, 2025
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

1 similar comment
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@Zuhair-CS Zuhair-CS changed the title (削除) Resolves #8140 (削除ここまで) (追記) Fix JavaScript lint errors #8140 (追記ここまで) Sep 25, 2025
@Zuhair-CS Zuhair-CS changed the title (削除) Fix JavaScript lint errors #8140 (削除ここまで) (追記) fix(lint): fix JavaScript lint errors (追記ここまで) Sep 25, 2025
@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Sep 26, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

AltStyle によって変換されたページ (->オリジナル) /