test: add tests to `ndarray/some-by` for complete test coverage #8125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kgryte merged 6 commits into stdlib-js:develop from headlessNode:tests-some-by

Sep 25, 2025

Merged

test: add tests to `ndarray/some-by` for complete test coverage #8125

kgryte merged 6 commits into stdlib-js:develop from headlessNode:tests-some-by

Sep 25, 2025

+3,995 −2

Conversation

headlessNode

Copy link

Member

@headlessNode headlessNode commented Sep 22, 2025

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: na
task: lint_package_json status: na
task: lint_repl_help status: na
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: na
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: na
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: na
task: lint_c_examples status: na
task: lint_c_benchmarks status: na
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: na
task: lint_typescript_tests status: na
task: lint_license_headers status: passed ---

Resolves stdlib-js/metr-issue-tracker#93.

Description

What is the purpose of this pull request?

This pull request:

add tests to ndarray/some-by for complete test coverage

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [BUG]: add tests to ndarray/some-by for complete test coverage metr-issue-tracker#93

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

@headlessNode


 test: add tests to ndarray/some-by for complete test coverage

6826ae9

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
 - task: lint_filenames
 status: passed
 - task: lint_editorconfig
 status: passed
 - task: lint_markdown
 status: na
 - task: lint_package_json
 status: na
 - task: lint_repl_help
 status: na
 - task: lint_javascript_src
 status: passed
 - task: lint_javascript_cli
 status: na
 - task: lint_javascript_examples
 status: na
 - task: lint_javascript_tests
 status: passed
 - task: lint_javascript_benchmarks
 status: na
 - task: lint_python
 status: na
 - task: lint_r
 status: na
 - task: lint_c_src
 status: na
 - task: lint_c_examples
 status: na
 - task: lint_c_benchmarks
 status: na
 - task: lint_c_tests_fixtures
 status: na
 - task: lint_shell
 status: na
 - task: lint_typescript_declarations
 status: na
 - task: lint_typescript_tests
 status: na
 - task: lint_license_headers
 status: passed
---

@stdlib-bot stdlib-bot added the Needs Review label

Sep 22, 2025

@stdlib-bot

Copy link

Contributor

stdlib-bot commented Sep 22, 2025 •

edited

Loading

Coverage Report

Package	Statements	Branches	Functions	Lines
ndarray/some-by	$\color{green}597/597$ $\color{green}+100.00\%$	$\color{green}80/80$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}597/597$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@headlessNode headlessNode requested a review from kgryte

September 22, 2025 10:09

@kgryte kgryte added the Tests label

Sep 22, 2025

kgryte

kgryte requested changes

Sep 23, 2025

View reviewed changes

Copy link

Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@headlessNode I made a number of changes to the tests in ndarray/any-by. I suggest going through and seeing what all should be carried over to here: #8110.

@kgryte kgryte added Needs Changes and removed Needs Review labels

Sep 23, 2025

kgryte

kgryte reviewed

Sep 23, 2025

View reviewed changes

lib/node_modules/@stdlib/ndarray/some-by/test/test.assign.js Outdated Show resolved Hide resolved

kgryte

kgryte reviewed

Sep 23, 2025

View reviewed changes

lib/node_modules/@stdlib/ndarray/some-by/test/test.assign.js Outdated Show resolved Hide resolved

headlessNode and others added 4 commits

September 23, 2025 13:56

@headlessNode


 Merge branch 'stdlib-js:develop' into tests-some-by

b0b9cb6

@headlessNode


 docs: apply suggestions from code review

d059154

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
 - task: lint_filenames
 status: passed
 - task: lint_editorconfig
 status: passed
 - task: lint_markdown
 status: na
 - task: lint_package_json
 status: na
 - task: lint_repl_help
 status: na
 - task: lint_javascript_src
 status: na
 - task: lint_javascript_cli
 status: na
 - task: lint_javascript_examples
 status: na
 - task: lint_javascript_tests
 status: passed
 - task: lint_javascript_benchmarks
 status: na
 - task: lint_python
 status: na
 - task: lint_r
 status: na
 - task: lint_c_src
 status: na
 - task: lint_c_examples
 status: na
 - task: lint_c_benchmarks
 status: na
 - task: lint_c_tests_fixtures
 status: na
 - task: lint_shell
 status: na
 - task: lint_typescript_declarations
 status: na
 - task: lint_typescript_tests
 status: na
 - task: lint_license_headers
 status: passed
---

@headlessNode


 refactor: apply suggestions from code review

5c98854

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
 - task: lint_filenames
 status: passed
 - task: lint_editorconfig
 status: passed
 - task: lint_markdown
 status: na
 - task: lint_package_json
 status: na
 - task: lint_repl_help
 status: na
 - task: lint_javascript_src
 status: na
 - task: lint_javascript_cli
 status: na
 - task: lint_javascript_examples
 status: na
 - task: lint_javascript_tests
 status: passed
 - task: lint_javascript_benchmarks
 status: na
 - task: lint_python
 status: na
 - task: lint_r
 status: na
 - task: lint_c_src
 status: na
 - task: lint_c_examples
 status: na
 - task: lint_c_benchmarks
 status: na
 - task: lint_c_tests_fixtures
 status: na
 - task: lint_shell
 status: na
 - task: lint_typescript_declarations
 status: na
 - task: lint_typescript_tests
 status: na
 - task: lint_license_headers
 status: passed
---

@headlessNode


 refactor: apply suggestions from code review

4bd3f8c

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
 - task: lint_filenames
 status: passed
 - task: lint_editorconfig
 status: passed
 - task: lint_markdown
 status: na
 - task: lint_package_json
 status: na
 - task: lint_repl_help
 status: na
 - task: lint_javascript_src
 status: na
 - task: lint_javascript_cli
 status: na
 - task: lint_javascript_examples
 status: na
 - task: lint_javascript_tests
 status: passed
 - task: lint_javascript_benchmarks
 status: na
 - task: lint_python
 status: na
 - task: lint_r
 status: na
 - task: lint_c_src
 status: na
 - task: lint_c_examples
 status: na
 - task: lint_c_benchmarks
 status: na
 - task: lint_c_tests_fixtures
 status: na
 - task: lint_shell
 status: na
 - task: lint_typescript_declarations
 status: na
 - task: lint_typescript_tests
 status: na
 - task: lint_license_headers
 status: passed
---

@headlessNode headlessNode requested a review from kgryte

September 23, 2025 10:28

@headlessNode headlessNode added Needs Review and removed Needs Changes labels

Sep 23, 2025

@kgryte


 test: add tests and clean-up

42af74f

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
 - task: lint_filenames
 status: passed
 - task: lint_editorconfig
 status: passed
 - task: lint_markdown
 status: na
 - task: lint_package_json
 status: na
 - task: lint_repl_help
 status: na
 - task: lint_javascript_src
 status: na
 - task: lint_javascript_cli
 status: na
 - task: lint_javascript_examples
 status: na
 - task: lint_javascript_tests
 status: passed
 - task: lint_javascript_benchmarks
 status: na
 - task: lint_python
 status: na
 - task: lint_r
 status: na
 - task: lint_c_src
 status: na
 - task: lint_c_examples
 status: na
 - task: lint_c_benchmarks
 status: na
 - task: lint_c_tests_fixtures
 status: na
 - task: lint_shell
 status: na
 - task: lint_typescript_declarations
 status: na
 - task: lint_typescript_tests
 status: na
 - task: lint_license_headers
 status: passed
---

@kgryte kgryte removed the Needs Review label

Sep 25, 2025

kgryte

kgryte approved these changes

Sep 25, 2025

View reviewed changes

@kgryte kgryte merged commit 95e69dc into stdlib-js:develop

Sep 25, 2025

12 checks passed

Labels

Tests

3 participants

@headlessNode @stdlib-bot @kgryte

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test: add tests to `ndarray/some-by` for complete test coverage #8125

test: add tests to `ndarray/some-by` for complete test coverage #8125

Conversation

@headlessNode headlessNode commented Sep 22, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Sep 22, 2025 •

edited

Loading

Uh oh!

Coverage Report

Uh oh!

@kgryte kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

test: add tests to ndarray/some-by for complete test coverage #8125

test: add tests to ndarray/some-by for complete test coverage #8125

Conversation

@headlessNode headlessNode commented Sep 22, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

@kgryte kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

test: add tests to `ndarray/some-by` for complete test coverage #8125

test: add tests to `ndarray/some-by` for complete test coverage #8125

stdlib-bot commented Sep 22, 2025 •

edited

Loading