-
-
Notifications
You must be signed in to change notification settings - Fork 873
feat: add math/base/special/fast/hypotf
#7998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/math/base/special/fast/hypotf/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/fast/hypotf/docs/repl.txt
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/fast/hypotf/test/test.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/fast/hypotf/test/test.native.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than some incorrect values, this PR is looking good.
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @nakul-krishnakumar, thanks for your PR! A few changes were missing, which have been addressed here: 18b2372...fe96d97. Just wanted to put this on your radar.
The main update was ensuring that input values and arithmetic operations are properly cast to Float32. If you’d like to learn more about how we handle single-precision in JS and why it’s important for single-precision implementations, this section might be a helpful read.
Cheers!
cc: @kgryte
Hi @nakul-krishnakumar, thanks for your PR! A few changes were missing, which have been addressed here: 18b2372...fe96d97. Just wanted to put this on your radar.
The main update was ensuring that input values and arithmetic operations are properly cast to
Float32. If you’d like to learn more about how we handle single-precision in JS and why it’s important for single-precision implementations, this section might be a helpful read.Cheers!
cc: @kgryte
Thank you for the review! I will make sure I do the necessary changes while working with single-precision implementations in the future. :)
PR-URL: #7998 Reviewed-by: Athan Reines <kgryte@gmail.com>
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves None.
Description
This pull request:
math/base/special/fast/hypotf.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers