-
-
Notifications
You must be signed in to change notification settings - Fork 874
feat: add ndarray/base/binary-reduce-strided1d-dispatch
#7908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ndarray/base/binary-reduce-strided1d-dispatch
#7908
Conversation
/stdlib merge
...ary-reduce-strided1d-dispatch
This PR is dependent on #7904.
/stdlib merge
...ary-reduce-strided1d-dispatch
Coverage Report
The above coverage report was generated for the changes in this PR. |
@gururaj1512 Now that #7904 is merged, is there anything else you want to do to this PR before review?
Note that I changed some of the logic in #7904. In particular, for each input ndarray, to determine the casting data type, one would do
var idt1 = getDType( x1 );
var idt2 = getDType( x2 );
var dt1 = binaryCastingDataType( idt1, idt2, odt, policy );
var dt2 = binaryCastingDataType( idt2, idt1, odt, policy );
Here, the first argument corresponds to the array dtype that you want to figure out the casting data type and the second argument corresponds to the "additional"/other input ndarray data type.
The lint failure seems to be due to a recently added lint rule which is buggy.
/stdlib merge
...ary-reduce-strided1d-dispatch
Resolves None
Description
This pull request:
ndarray/base/binary-reduce-strided1d-dispatchRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers