-
-
Notifications
You must be signed in to change notification settings - Fork 896
Fix: implement circularBuffer type checks #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: implement circularBuffer type checks #480
Conversation
lib/node_modules/@stdlib/utils/circular-buffer/docs/types/test.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/utils/circular-buffer/docs/types/test.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/utils/circular-buffer/docs/types/test.ts
Outdated
Show resolved
Hide resolved
Thanks, @mohamadaminkarami, for your interest in contributing to stdlib. I looked over the PR and some updates need to be made.
For clarity, this PR, as it currently stands, does not full address #474. The entire API surface includes various prototype methods which would need to be tested in order for that issue to be closed. See circular-buffer.
@mohamadaminkarami Would you mind checking the box in the OP, indicating that you've read the contributing guidelines? This is necessary for licensing and the project's ability to use code that you contribute.
Resolves #474 .
Description
This pull request:
Related Issues
This pull request:
@stdlib/utils/circular-buffer#474Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers