-
-
Notifications
You must be signed in to change notification settings - Fork 896
feat: add constants/lapack/dsafmin
#2859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Pranavchiku
Pranavchiku
added
Feature
Issue or pull request for adding a new feature.
JavaScript
Issue involves or relates to JavaScript.
C
Issue involves or relates to C.
LAPACK
Issue or pull request related to the Linear Algebra Package (LAPACK).
constants
labels
Sep 3, 2024
@Planeshifter
Planeshifter
added
the
Needs Review
A pull request which needs code review.
label
Sep 3, 2024
Planeshifter
Planeshifter
requested changes
Sep 6, 2024
#### FLOAT64_LAPACK_SAFE_MIN
The minimum [safe][safe] [double-precision floating-point][ieee754] integer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the description should be changed here and elsewhere to e.g.
Suggested change
The minimum [safe][safe] [double-precision floating-point][ieee754] integer.
The smallest positive [safe][safe] [double-precision floating-point][ieee754] number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied changes.
@Planeshifter
Planeshifter
added
Needs Changes
Pull request which needs changes before being merged.
and removed
Needs Review
A pull request which needs code review.
labels
Dec 19, 2024
/stdlib merge
@stdlib-bot
stdlib-bot
added
the
bot: In Progress
Pull request is currently awaiting automation.
label
Jan 14, 2025
@stdlib-bot
stdlib-bot
removed
the
bot: In Progress
Pull request is currently awaiting automation.
label
Jan 14, 2025
Coverage Report
The above coverage report was generated for the changes in this PR. |
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---
@aman-095
aman-095
removed
the
Needs Changes
Pull request which needs changes before being merged.
label
Jan 14, 2025
@kgryte
kgryte
added
Needs Discussion
Needs further discussion.
Do Not Merge
Pull request which should not be merged.
labels
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2464.
Description
This pull request adds macro for constant
dsafmin.Related Issues
NA
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers