Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: add lapack/base/dtrti2 #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pranavchiku wants to merge 7 commits into stdlib-js:develop
base: develop
Choose a base branch
Loading
from Pranavchiku:dtrti2

Conversation

Copy link
Member

@Pranavchiku Pranavchiku commented Aug 6, 2024 •
edited
Loading

Towards #2464.

Description

What is the purpose of this pull request?

This pull request adds JS implementation for lapack/base/dtrti2

Related Issues

Does this pull request have any related issues?

NA

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines.
  • refactor base implementation ( possible optimisations )

@stdlib-js/reviewers

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. JavaScript Issue involves or relates to JavaScript. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). labels Aug 6, 2024
Copy link
Member Author

The latest commit considers row-major upper === column-major lower, etc.

@Pranavchiku Pranavchiku marked this pull request as ready for review August 6, 2024 15:58
if ( upper ) {
for ( j = 0; j < N; j++ ) {
if ( nounit ) {
A[ offsetA + ( j * strideA1 ) + ( j * strideA2 ) ] = 1.0 / A[ offsetA + ( j * strideA1 ) + ( j * strideA2 ) ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor to reduce flops.

}
});

tape( 'the function correctly computes inverse of upper triangular non-unit matrix ( row-major )', function test( t ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tape( 'the function correctly computes inverse of upper triangular non-unit matrix (row-major)', function test( t ) {
tape( 'the function correctly computes inverse of upper triangular non-unit matrix (row-major)', function test( t ) {

Remove spaces here and in other test descriptions.

t.end();
});

tape( 'the function correctly computes inverse of lower triangular non-unit rectangular matrix ( row-major )', function test( t ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your descriptions, parameterize to help distinguish. For example, row-major, lower, non-unit. Applies here and elsewhere.

}
});

tape( 'the function supports accessing elements from non-contiguous alignment of row and column ( row-major )', function test( t ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor to include more systematic tests. Test to the interface, not the implementation.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Sep 17, 2024
Copy link
Member

/stdlib merge
stdlib-bot reacted with eyes emoji

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 14, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 14, 2025
Copy link
Contributor

stdlib-bot commented Jan 14, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
lapack/base/dtrti2 $\color{green}343/343$
$\color{green}+100.00\%$ 		$\color{green}32/32$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}343/343$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

kgryte commented Jan 14, 2025

/stdlib update-copyright-years
stdlib-bot reacted with eyes emoji

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 14, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 14, 2025

The function has the following parameters:

- **order**: storage layout.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /