Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: add math/base/special/acosd #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Planeshifter merged 7 commits into stdlib-js:develop from saisrikardumpeti:acosd
Mar 12, 2024

Conversation

Copy link
Contributor

@saisrikardumpeti saisrikardumpeti commented Mar 8, 2024 •
edited
Loading

Resolves #36

Description

What is the purpose of this pull request?

This pull request:

  • Adds functionality to compute acosd of any given input.
  • Say we have input x, so it should satisfies this x <= 1 or x >= -1 else it will return NaN
input acosd
0 90
0.5 60
$\frac{1}{\sqrt{2}}$ 45
$\frac{\sqrt{3}}{2}$ 30
1 0

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter changed the title (削除) feat: add math/base/special/acosd (削除ここまで) (追記) feat: add math/base/special/acosd (追記ここまで) Mar 8, 2024
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Math Issue or pull request specific to math functionality. JavaScript Issue involves or relates to JavaScript. labels Mar 8, 2024
saisrikardumpeti and others added 5 commits March 10, 2024 00:07 
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
Copy link
Contributor Author

@Planeshifter this PR is ready for review.

 

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Copy link
Member

Will merge after CI has passed; thank you for getting this PR over the finish line!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement acosd

AltStyle によって変換されたページ (->オリジナル) /