-
-
Notifications
You must be signed in to change notification settings - Fork 409
Added optional cache-control header to static config#1602
Open
indykoning wants to merge 1 commit intostatamic:5.x from
Open
Added optional cache-control header to static config #1602indykoning wants to merge 1 commit intostatamic:5.x from
indykoning wants to merge 1 commit intostatamic:5.x from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're statically serving these files anyways we can instruct the browser and a proxy (like cloudflare) to cache these files (in the examples 2 minutes with an hour to revalidate before it must serve directly from the server)
Note: Cloudflare will by default not cache pages ever, a cache rule can be created to respect the cache-control header