-
-
Notifications
You must be signed in to change notification settings - Fork 611
[6.x] Prevent dropping nav item with children into root position#13861
Open
duncanmcclean wants to merge 1 commit into6.x from
Open
[6.x] Prevent dropping nav item with children into root position #13861duncanmcclean wants to merge 1 commit into6.x from
duncanmcclean wants to merge 1 commit into6.x from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where it was possible to drag & drop a nav item with children into the root position. Root nav items can't have children.
We were previously passing a hook via the
rootDroppableprop to handle this. Although, it wasn't working (the hook is called when you drag items, not when you drop them) and was removed in #12582.This PR attempts to fix it by checking the new root entry in the
afterDropevent listener.Closes #13826