-
-
Notifications
You must be signed in to change notification settings - Fork 611
[6.x] Fix nav:breadcrumbs for multi-site#13789
Open
nopticon wants to merge 3 commits intostatamic:6.x from
Open
[6.x] Fix nav:breadcrumbs for multi-site #13789nopticon wants to merge 3 commits intostatamic:6.x from
nopticon wants to merge 3 commits intostatamic:6.x from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
What is the issue
Using {{ nav:breadcrumbs }} on multi-site, it fails to generate links when Site URL is configured as:
{{ config:app:url }}/path/So for example you can go to collection route with parent and children like:
https://example.test/path/entry/child/sub-childIt generates just one link to "Home", no other links to navigate backwards.
imageWhat this PR Does
It generates the correct links now for all kind of site configs. It respects new enforceTrailingSlashes.
imageRelated #11840