-
Notifications
You must be signed in to change notification settings - Fork 280
Import the TypeScript definition for StackFrame from stackframe #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@andersk
andersk
force-pushed
the
typescript-import
branch
from
February 12, 2022 02:49
632c7c9 to
06a7ca2
Compare
The slight incompatibility of the old definition was necessitating unsafe casts between StackTrace.StackFrame and StackFrame. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk
andersk
force-pushed
the
typescript-import
branch
from
February 12, 2022 02:50
06a7ca2 to
f076e06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The slight incompatibility of the old definition was necessitating unsafe casts between
StackTrace.StackFrameandStackFrame. See also stacktracejs/error-stack-parser#54.Types of changes
Checklist:
node_modules/.bin/jscs -c .jscsrc stacktrace.jspasses without errorsnpm testpasses without errors