-
Notifications
You must be signed in to change notification settings - Fork 102
feat: introduce an ImageContent component in editor #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problems left:
somehow the editor displays code from another file alongside the image
The existing <BinaryContent /> does too, but it uses position: absolute; inset: 0 to cover the text area. We could do same here:
This isn't actually good approach as the text content of previous file is still present in DOM. It's part of tab and read order so users can actually navigate to this invisible element. But as this bug is already present in TutorialKit we can ignore it on this PR. 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a leftover of a time where we were trying to cache the EditorView from CodeMirror which I don't think is necessary. We should change the logic so that the CodeMirrorEditor is not rendered in that case.
This PR introduces an ImageContent component for the editor, for binary images.
Design choices:
Problems left:
image
Closes #309