-
-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
...actors Upgrade workspace and crates to Rust 2024 edition and apply tool-driven fixes: - Bump Rust edition from 2021 to 2024 across workspace crates (Cargo.toml, Cargo.nix) - Update `rustls-webpki` dependency to 0.103.13 - Apply `cargo fix --edition` changes - Add `use<>` lifetime capture in `impl Trait` return types for iterators - Apply Clippy suggestions and minor refactors - Simplify iterator-returning functions with correct lifetime capture syntax - Refactor `trystream_any` to fix warning
ea1e686 to
fd0995b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally found the existing code a bit easier to read to be honest.
But I let you decide if we want to keep it and silence clippy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too, I agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case I suggest we slap a #[allow(clippy::xxx)] at the existing code and keep that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a bit of mixed feelings about touching rust/p12. As documented in rust/p12/README.md it's a fork of https://github.com/hjiayz/p12/. We can hopefully get rid of it eventually.
So it's nice to maintain it, on the other hand this increases the diff to upstream...
Explicitly selecting TryFutureExt::into_future
Uh oh!
There was an error while loading. Please reload this page.
Upgrade workspace and crates to Rust 2024 edition and apply tool-driven fixes:
rustls-webpkidependency to 0.103.13 to fix security vulnerability warningscargo fix --editionchangesuse<>lifetime capture inimpl Traitreturn types for iteratorstrystream_anyto fix warningPart of Bump our Rust code to 2024 edition issues#832
Description
Please add a description here. This will become the commit message of the merge request later.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker