-
Notifications
You must be signed in to change notification settings - Fork 586
Comments
Conversation
nickplee
commented
Dec 19, 2016
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dkavraal, thank you for submitting these changes! I left one minor note about a log statement that should be removed, and have one other question before merging: Is there any way we could restrict the cross-origins we allow to prevent any possible security issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove this log statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving myself a link to the documentation for the check_origin method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw. Sorry, for a while I won't have the chance to check this.
/:404 error, devtools:403 error and Cross-origin-not-allowed error.
Issue#190
Issue#194
Thanks to comments of kenichi and julien gomez