@codex I clearly see the runtime overhead, but not the concrete benefits. We are making one entire new db query per file, for no functional change ? Either justify it or drop it

Summary

• Dropped the source-mtime/Last-Modified changes and restored the prior static-file serving behavior, so ordinary database-backed file responses no longer perform an additional metadata query before reading the file. Conditional requests still perform only the existing modified-since check. src/webserver/http.rsL438-L470
• Retained the concrete correctness fix: database-backed files are now considered modified only when last_modified is strictly greater than the supplied timestamp. src/filesystem.rsL301-L312
• Added regression coverage confirming that a database-backed file is not considered modified since its exact modification timestamp. src/filesystem.rsL478-L492
• Committed the changes with commit 85eec98 (Avoid extra query for static file metadata) and created the follow-up PR "Avoid extra query for static file metadata."

Testing

• ✅ cargo fmt --all
• ✅ cargo fmt --all -- --check
• ✅ git diff --check
• ⚠️ cargo test — blocked by the environment because libsqlite3-sys 0.38.1 uses the unstable Rust cfg_select feature.
• ⚠️ cargo clippy --all-targets --all-features -- -D warnings — blocked by the same libsqlite3-sys 0.38.1 build error.

View task →

@codex monitor ci

error[E0283]: type annotations needed
--> src/webserver/http.rs:448:54
|
448 | let last_modified = HttpDate::from(last_modified.into());
| -------- ^^^^
| |
| type must be known at this point
|
= note: multiple impls satisfying actix_web::http::header::HttpDate: std::convert::From<_> found in the following crates: actix_http, core:
- impl std::convert::Fromstd::time::SystemTime for actix_web::http::header::HttpDate;
- impl std::convert::From for T;
help: try using a fully qualified path to specify the expected types
|
448 - let last_modified = HttpDate::from(last_modified.into());
448 + let last_modified = HttpDate::from(<chrono::DateTimechrono::Utc as std::convert::Into>::into(last_modified));
|

error[E0283]: type annotations needed
--> src/webserver/http.rs:448:54
|
448 | let last_modified = HttpDate::from(last_modified.into());
| ^^^^
|
= note: multiple impls satisfying _: std::convert::From<chrono::DateTime<chrono::Utc>> found in the chrono crate:
- impl std::convert::From<chrono::DateTimechrono::Utc> for chrono::DateTimechrono::FixedOffset;
- impl std::convert::From<chrono::DateTimechrono::Utc> for chrono::DateTimechrono::Local;
= note: required for chrono::DateTime<chrono::Utc> to implement std::convert::Into<_>
help: try using a fully qualified path to specify the expected types
|
448 - let last_modified = HttpDate::from(last_modified.into());
448 + let last_modified = HttpDate::from(<chrono::DateTimechrono::Utc as std::convert::Into>::into(last_modified));
|

For more information about this error, try rustc --explain E0283.
error: could not compile sqlpage (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile sqlpage (lib test) due to 2 previous errors
Error: Process completed with exit code 101.

You have reached your Codex usage limits. You can see your limits in the Codex usage dashboard.